Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TreeData): add auto-recalc feature for Tree Totals w/Aggregators #1084

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 19, 2023

  • add a new auto-recalc tree totals feature which is disabled by default, this new feature comes with 2 new properties
    • autoRecalcTotalsOnFilterChange to enabled the feature
    • autoRecalcTotalsDebounce to limit recalc execution when used with large tree dataset
  • add more functionalities into Example 6 to not just add new file but also remove last inserted song

TODOs

  • add Jest unit tests
  • add Cypress E2E tests

- add a new auto-recalc tree totals feature which is disabled by default, this new feature comes with 2 new properties
  - `autoRecalcTotalsOnFilterChange` to enabled the feature
  - `autoRecalcTotalsDebounce` to limit recalc execution when used with large tree dataset
- add more functionalities into Example 6 to not just add new file but also remove last inserted song
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #1084 (54686a3) into master (6af5fd1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1084   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        16798     16838   +40     
  Branches      6030      6043   +13     
=========================================
+ Hits         16798     16838   +40     
Files Changed Coverage Δ
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/treeData.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/utilities.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit e884c03 into master Aug 19, 2023
@ghiscoding ghiscoding deleted the feat/auto-recalc-tree-totals branch August 19, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant