Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add missing row selections preset option #11

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #11 into master will decrease coverage by 0.08%.
The diff coverage is 55.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   95.40%   95.32%   -0.07%     
==========================================
  Files         183      184       +1     
  Lines        9771     9799      +28     
  Branches     3227     3235       +8     
==========================================
+ Hits         9321     9340      +19     
- Misses        450      459       +9     
Impacted Files Coverage Δ
packages/vanilla-bundle/src/vanilla-grid-bundle.ts 3.37% <0.00%> (-0.06%) ⬇️
packages/common/src/formatters/index.ts 100.00% <100.00%> (ø)
...mmon/src/formatters/percentCompleteBarFormatter.ts 100.00% <100.00%> (ø)
.../formatters/percentCompleteBarWithTextFormatter.ts 100.00% <100.00%> (ø)
.../common/src/formatters/percentCompleteFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c9903...8a651f2. Read the comment docs.

same as percentCompleteBarFormatter but makes the progress bar thicker and also adds the % text inside the progress bar
- the Tree Data must execute pre-filtering with Tree Data when having Grid Preset Filters
@ghiscoding ghiscoding merged commit e0a729c into master Jul 13, 2020
@ghiscoding ghiscoding deleted the feat/preset-row-selections branch July 13, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants