Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): mouseover disabled sub-menu shouldn't open it #1167

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 31, 2023

  • the logic should be the same as the sub-menu click event, if the item is disabled (or is a didiver), then we shouldn't go further and not try to open it

brave_0FSycfkAN1

- the logic should be the same as the sub-menu click event, if the item is disabled (or is a didiver), then we shouldn't go further and not try to open it
@codecov
Copy link

codecov bot commented Oct 31, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@ghiscoding ghiscoding merged commit 550f103 into master Oct 31, 2023
3 checks passed
@ghiscoding ghiscoding deleted the bugfix/menu-mouseover-disabled-item branch October 31, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant