Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gridMenu): remove GridMenu from DOM after closing it #1169

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

ghiscoding
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1169 (2a75dbd) into master (bc02092) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1169   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17240     17242    +2     
  Branches      6231      6232    +1     
=========================================
+ Hits         17240     17242    +2     
Files Coverage Δ
packages/common/src/extensions/slickGridMenu.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit 87b242f into master Nov 1, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/grid-menu-close-empty-menu branch November 1, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant