perf: skip reapplying empty html when target is already empty #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when calling `applyHtmlCode()` method and our target element is empty and we try to reapply empty, it should always be ok to simply skip this reassignment. - this should also help with performance since trying to reapply empty using `innerHTML` will probably cause a canvas repaint but if we manage to skip this then a repaint will also be skipped - this should also help with CSP because we could write a Formatter with native element while still returning empty string when there's no value to return, that will then call `applyHtmlCode` and skip the assignment if the cell is already empty
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1230 +/- ##
==========================================
- Coverage 86.11% 86.10% -0.00%
==========================================
Files 197 197
Lines 21245 21248 +3
Branches 7066 7067 +1
==========================================
+ Hits 18292 18294 +2
- Misses 2953 2954 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyHtmlCode()method and our target element is empty and we try to reapply empty, it should always be ok to simply skip this reassignment.innerHTMLwill probably cause a canvas repaint but if we manage to skip this then a repaint will also be skippedapplyHtmlCodeand skip the assignment since the cell was already detected as empty