Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce devMode to support nodejs based unit testing #1251

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ghiscoding
Copy link
Owner

as the title suggests this is meant to make unit/integration tests, e.g with testing-library, possible for apps using Slickgrid. In my specific case I'm making use of angular-slickgrid and would like to be able to test my app using angular-testing-library.

The introduced devMode workarounds are in order to work around the following jsdom issues:

jsdom/jsdom#2310 (missing clientWidth) jsdom/jsdom#992 (missing ownerNode, even with a nice reference to Slickgrid ;) ) For additional conversations about this topic please refer to ghiscoding/Angular-Slickgrid#1319

- copies implementation made in 6pac/SlickGrid repo at 6pac/SlickGrid#946
> as the title suggests this is meant to make unit/integration tests, e.g with testing-library, possible for apps using Slickgrid. In my specific case I'm making use of angular-slickgrid and would like to be able to test my app using angular-testing-library.
>
> The introduced devMode workarounds are in order to work around the following jsdom issues:
>
> [jsdom/jsdom#2310](jsdom/jsdom#2310) (missing clientWidth) [jsdom/jsdom#992](jsdom/jsdom#992) (missing ownerNode, even with a nice reference to Slickgrid ;) ) For additional conversations about this topic please refer to [ghiscoding/Angular-Slickgrid#1319](ghiscoding/Angular-Slickgrid#1319)
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (102e299) 86.53% compared to head (3fde9b2) 86.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1251      +/-   ##
==========================================
+ Coverage   86.53%   86.54%   +0.01%     
==========================================
  Files         196      196              
  Lines       21380    21381       +1     
  Branches     7098     7099       +1     
==========================================
+ Hits        18500    18501       +1     
  Misses       2880     2880              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 596737d into next Dec 7, 2023
5 checks passed
@ghiscoding ghiscoding deleted the feat/slickgrid-dev-mode-test branch December 7, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant