Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): add Toggle Filtering/Sorting & Hide Column methods #126

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Sep 18, 2020

  • The new methods are:
    • filterService.toggleFilterFunctionality()
    • sortService.toggleSortFunctionality()
    • gridService.hideColumnByIndex(columnIndex)
    • gridService.hideColumn(column)

Ghislain Beaulac added 2 commits September 18, 2020 19:15
- The new methods are:
   - `filterService.toggleFilteringFunctionality()`
   - `sortService.toggleSortingFunctionality()`
   - `gridService.hideColumnByIndex(columnIndex)`
   - `gridService.hideColumn(column)
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #126    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          195       195            
  Lines        11148     11193    +45     
  Branches      3757      3645   -112     
==========================================
+ Hits         11148     11193    +45     
Impacted Files Coverage Δ
packages/common/src/extensions/extensionUtility.ts 100.00% <ø> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/sort.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/utilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f77de9...dbfb2c7. Read the comment docs.

@ghiscoding ghiscoding merged commit 08fe2e1 into master Sep 21, 2020
@ghiscoding ghiscoding deleted the feat/toggle-filtering-sorting branch September 21, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant