Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow extra spaces in headerCssClass #1303

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 2, 2024

Follows SlickGrid PR 960

Extra spaces in class dom attribute are allowed in html (e.g. class="some-class other-class "). SlickGrid should probably also behave the same way (or at least fail with some meaningfull validation error).

This commit just ignores all extra spaces in headerCssClass (between individual classes or leading / trailing).

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0102b5) 94.7% compared to head (77ac541) 94.7%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1303     +/-   ##
========================================
+ Coverage    94.7%   94.7%   +0.1%     
========================================
  Files         198     198             
  Lines       21314   21317      +3     
  Branches     7087    7085      -2     
========================================
+ Hits        20182   20185      +3     
  Misses       1132    1132             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 59ebaa6 into master Jan 2, 2024
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/css-classes-string-split branch January 2, 2024 21:47
@ghiscoding ghiscoding changed the title fix: allow extra spaces in headerCssClass fix(core): allow extra spaces in headerCssClass Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant