fix(core): remove editor keydown keyCaptureList duplicate code #1322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate code exist at line shown below, so there's no need to keep keydown keyCaptureList duplicate code. I found this duplicate code while adding unit tests and the piece of code that I'm removing seems unreachable, hence why I'm removing it
slickgrid-universal/packages/common/src/core/slickGrid.ts
Lines 4754 to 4760 in 801bd4c
so we can remove duplicate code appearing with a slight different if condition
slickgrid-universal/packages/common/src/core/slickGrid.ts
Lines 4769 to 4775 in 801bd4c