fix(core): EventHandler subscribed event should be SlickEventData type #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
========================================
+ Coverage 98.0% 98.0% +0.1%
========================================
Files 198 198
Lines 21284 21286 +2
Branches 7093 7098 +5
========================================
+ Hits 20845 20847 +2
Misses 439 439 ☔ View full report in Codecov by Sentry. |
ghiscoding
pushed a commit
that referenced
this pull request
Jan 12, 2024
- continuation of previous PR #1327 to add proper types to SlickEventHandler arguments
ghiscoding
added a commit
that referenced
this pull request
Jan 12, 2024
* fix(core): SlickEvent handler event should be type of ArgType - continuation of previous PR #1327 to add proper types to SlickEventHandler arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anybut in practical it will always be of typeSlickEventDatabecause a SlickEvent.notify()method always passes aSlickEventDatainstance as 1st argument