Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add custom entry to Select Editor/Filter collections #133

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

ghiscoding
Copy link
Owner

  • add 2 new methods (addCustomFirstEntry, addCustomLastEntry) to optionally add entry on both end of the collection

- add 2 new methods (`addCustomFirstEntry`, `addCustomLastEntry`) to optionally add entry on both end of the collection
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11225     11245   +20     
  Branches      3802      3812   +10     
=========================================
+ Hits         11225     11245   +20     
Impacted Files Coverage Δ
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34f6b2...6c33fd8. Read the comment docs.

@ghiscoding ghiscoding merged commit 66effcf into master Sep 30, 2020
@ghiscoding ghiscoding deleted the feat/collection-add-custom-entry branch September 30, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant