feat: convert CheckSelectColumn plugin to native HTML for CSP safe code #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change Column interface `name` to also accept `DocumentFragment` - change `headerColumnValueExtractor` to also accept `DocumentFragment` - add `getHtmlStringOutput()` util to get HTML from any type of input (string, number, HTMLElement or DocumentFragment), which is especially useful with `DocumentFragment` which doesn't return HTML by default
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1332 +/- ##
========================================
+ Coverage 98.5% 98.5% +0.1%
========================================
Files 198 198
Lines 21278 21283 +5
Branches 7099 7097 -2
========================================
+ Hits 20943 20948 +5
Misses 335 335 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameto also acceptDocumentFragmentheaderColumnValueExtractorto also acceptDocumentFragmentgetHtmlStringOutput()util to get HTML from any type of input (string, number, HTMLElement or DocumentFragment), which is especially useful withDocumentFragmentwhich doesn't return HTML by defaultI think (hope) this is the last piece to convert to native element for CSP safe approach