fix: mouse cell selection with active editor

[zewa666]

this fixes errors preventing to do a multi cell selection while an editor is opened.

Closes #1380

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bac08b0) 99.8% compared to head (fc104ad) 99.8%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1382     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         199     199             
  Lines       21549   21557      +8     
  Branches     7200    7067    -133     
========================================
+ Hits        21486   21493      +7     
+ Misses         63      58      -5     
- Partials        0       6      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ghiscoding]

oops looks like you forgot to remove .only after you're done 😉

[zewa666]

yeah thats super unfortunate ... I've added eslint-plugin-jest to detect those. Than started to fix the main ones by adjusting the the eslintignore file. As soon as I touched tests though, ~250 errors came up. So those should be handled in a separate shot not to mess up this PR

[ghiscoding]

hmm yeah that's just linting cosmetic though, it should indeed be better to add ESLint stuff as a separate PR. It looks like there's still a failing test though. It also looks like there's a line coverage missing too :)

[zewa666]

ok I think I got it set now. so what I've essentially changed is to apply previous behaviors only if the selected/iterated cell isn't the active editor cell. That means you still can't do a multi-select starting from the editor cell but it works for all others. I could have changed that as well with the original behavior from the patch I've mentioned, but this felt as the safer way, while fixing enough of the bug itself

[ghiscoding]

ok I think I got it set now. so what I've essentially changed is to apply previous behaviors only if the selected/iterated cell isn't the active editor cell. That means you still can't do a multi-select starting from the editor cell but it works for all others.

that seems fine by me, I'm assuming most of the time it will be from another cell anyway. Thanks for the fix :)