Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): disable Husky when pushing new release #1390

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 13, 2024

  • as per issue identified in this comment
  • Husky that was added recently and caused an issue with the last release, the typical chore(release) commit was completely missing in today's release, possibly because of a racing condition or a prompt that cannot be answered in a CI environment
  • as per Husky docs we can disable Husky via
env:
  HUSKY: 0

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd68be5) 99.8% compared to head (5382ab0) 99.8%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1390    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         199     199            
  Lines       21557   21557            
  Branches     7203    7067   -136     
=======================================
  Hits        21493   21493            
  Misses         58      58            
  Partials        6       6            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 6f9372e into master Feb 13, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/husky-disable-when-releasing branch February 13, 2024 04:58
@zewa666
Copy link
Contributor

zewa666 commented Feb 13, 2024

good morning. super sorry for that didnt think that you're performing git pushes on ci during your release. glad you figured it out though

@ghiscoding
Copy link
Owner Author

ghiscoding commented Feb 13, 2024

yeah just pieced it back together, it's kinda late here though hehe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants