Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): clear dataset when disposing and fix few unsubscribed events to avoid leak #156

Merged
merged 18 commits into from
Nov 12, 2020

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #156 (1df2788) into master (073edd8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #156    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          198       198            
  Lines        11556     11626    +70     
  Branches      3943      3813   -130     
==========================================
+ Hits         11556     11626    +70     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/textEditor.ts 100.00% <100.00%> (ø)
...src/extensions/cellExternalCopyManagerExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/cellMenuExtension.ts 100.00% <100.00%> (ø)
...common/src/extensions/checkboxSelectorExtension.ts 100.00% <100.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073edd8...1df2788. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(core): do not keep dataset local copy avoid leak when disposing fix(core): clear dataset when disposing and fix few unsubscribed events to avoid leak Nov 12, 2020
@ghiscoding ghiscoding merged commit 78c80b4 into master Nov 12, 2020
@ghiscoding ghiscoding deleted the bugfix/dataset-leak branch November 12, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant