Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): GraphQL Custom Filter Operator could be anything #1562

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 8, 2024

  • e.g. the Example 10 creates a new Like operator is not part of the current OperatorType list. So it should really accept any type as custom operator (as long as the end user deals with this new type on their end)

Copy link

stackblitz bot commented Jun 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (7c61846) to head (eb39350).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1562    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21727   21727            
  Branches     7135    7273   +138     
=======================================
  Hits        21666   21666            
  Misses         55      55            
  Partials        6       6            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 5430486 into master Jun 8, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/any-custom-operator branch June 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant