-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filters): add new optional filterShortcuts
to Column Filter
#1575
Conversation
Run & review this pull request in StackBlitz Codeflow. |
so the only thing I'm not sure is the position in the Column Header Menu, it's starting to be crowded a little. I think it's ok where I've put it but just in case, I also expose a configurable I might also keep it only available on the Column Filter for now, I'm not sure I want to spend time on adding it to the Grid Option since that doesn't seem to be much of a request for now. Note that you can try a live demo by clicking the Stackblitz button just above |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1575 +/- ##
========================================
+ Coverage 99.8% 99.8% +0.1%
========================================
Files 198 198
Lines 21746 21759 +13
Branches 7282 7287 +5
========================================
+ Hits 21685 21698 +13
Misses 55 55
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Hey @ghiscoding - I think this looks pretty good and I don't feel it's crowded at all! Go for it! |
great work, looks sweet. looking forward to this one |
@zewa666 I released everything last night, we should be good for a while (I would think anyway 😄)... oh well I say that and I just found and fixed another small issue but it's small and that can definitely wait. Cheers and thanks for all |
awesome, thx a lot gonna give it a try tomorrow |
closes #1569
title
(ortitleKey
) and asearchTerms
array, lastly an optionaloperator
can also be providedcommand
andaction
which are reserved) and an addition of our required props which are the extrasearchTerms
andoperator
(which as you can guess are the same props as a Column Filter for example what we use inpreset
)TODOs
demo