Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): Slider Filter should auto update tooltip whenever sliding #1584

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 22, 2024

  • slider tooltip is more useful when its tooltip is updated while sliding, the onHeaderRowMouseEnter was missing as a Custom Tooltip listener

msedge_8oVFA7aYdk

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (92f6164) to head (b5721f3).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1584     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         198     198             
  Lines       21776   21777      +1     
  Branches     7293    7012    -281     
========================================
+ Hits        21715   21716      +1     
- Misses         55      61      +6     
+ Partials        6       0      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 4d56dfb into master Jun 22, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/slider-filter-tooltip-update branch June 22, 2024 05:25
Copy link

stackblitz bot commented Jun 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant