Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): extract CompositeEditor & EmptyWarning Components #191

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

ghiscoding
Copy link
Owner

  • extract into 2 separate monorepo packages so it can be used in other frameworks like Aurelia-Slickgrid
  • keep full unit test coverage on both components

- extract into 2 separate monorepo packages so it can be used in other frameworks like Aurelia-Slickgrid
- keep full unit test coverage on both components
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #191 (8573fca) into master (b856c47) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          202       204    +2     
  Lines        11779     11781    +2     
  Branches      4025      4025           
=========================================
+ Hits         11779     11781    +2     
Impacted Files Coverage Δ
...-component/src/slick-composite-editor.component.ts 100.00% <ø> (ø)
...ing-component/src/slick-empty-warning.component.ts 100.00% <ø> (ø)
packages/composite-editor-component/src/index.ts 100.00% <100.00%> (ø)
packages/empty-warning-component/src/index.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)
packages/vanilla-bundle/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b856c47...8573fca. Read the comment docs.

@ghiscoding ghiscoding merged commit 00cf9a2 into master Dec 10, 2020
@ghiscoding ghiscoding deleted the feat/composite-empty-warning-components branch December 10, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant