Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): refactor to use registerExternalResources grid option #199

Merged
merged 3 commits into from
Dec 15, 2020

Conversation

ghiscoding
Copy link
Owner

  • create new ExternalResource interface and make all external resources (components/services) implement it

- create new ExternalResource interface and make all external resources (components/services) implement it
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #199 (7c9eddb) into master (6789e25) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #199    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          206       206            
  Lines        11834     11839     +5     
  Branches      4044      3896   -148     
==========================================
+ Hits         11834     11839     +5     
Impacted Files Coverage Δ
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)
...ackages/common/src/services/excelExport.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/textExport.service.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)
...ing-component/src/slick-empty-warning.component.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
packages/text-export/src/textExport.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6789e25...7c9eddb. Read the comment docs.

@ghiscoding ghiscoding merged commit 7ca42f4 into master Dec 15, 2020
@ghiscoding ghiscoding deleted the bugfix/external-resource-interface branch December 15, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant