Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add mass update feat to Example 11 #31

Merged
merged 4 commits into from
Jul 31, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 30, 2020

  • add a Mass Update (modal window) functionality via the Grid Menu and/or Context Menu. The Mass Update can be done for the entire dataset (when no rows are selected) or a set of selected rows

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #31 into master will increase coverage by 0.22%.
The diff coverage is 98.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   99.60%   99.82%   +0.22%     
==========================================
  Files         185      186       +1     
  Lines       10062    10095      +33     
  Branches     3307     3313       +6     
==========================================
+ Hits        10021    10076      +55     
+ Misses         41       19      -22     
Impacted Files Coverage Δ
...bundle/src/components/slick-vanilla-grid-bundle.ts 96.57% <50.00%> (-0.16%) ⬇️
packages/common/src/aggregators/avgAggregator.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/cloneAggregator.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/countAggregator.ts 100.00% <100.00%> (ø)
...kages/common/src/aggregators/distinctAggregator.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/index.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/maxAggregator.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/minAggregator.ts 100.00% <100.00%> (ø)
packages/common/src/aggregators/sumAggregator.ts 100.00% <100.00%> (ø)
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe132a4...ff8fcae. Read the comment docs.

- seems like it was working only when "enableTranslate" was active, it should now work in both cases with/without translations
- add a Mass Update (modal window) functionality via the Grid Menu and/or Context Menu. The Mass Update can be done for the entire dataset (when no rows are selected) or a set of selected rows
@ghiscoding ghiscoding changed the title feat(tests): add some new Aggregators with unit tests feat(examples): add mass demo for example 11 Jul 31, 2020
@ghiscoding ghiscoding changed the title feat(examples): add mass demo for example 11 feat(examples): add mass demo to Example 11 Jul 31, 2020
@ghiscoding ghiscoding changed the title feat(examples): add mass demo to Example 11 feat(examples): add mass update feat to Example 11 Jul 31, 2020
@ghiscoding ghiscoding merged commit 84e9817 into master Jul 31, 2020
@ghiscoding ghiscoding deleted the feat/mass-update branch July 31, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants