Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composite): selected row count always 0 on mass-selected #712

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

ghiscoding
Copy link
Owner

  • add dispose method to container service to start with a blank array whenever we route to another page, this is to avoid reusing already disposed services that might still be in the container service
  • the issue was found in Angular-Slickgrid and did not seem to show up as a problem in Slickgrid-Universal itself but better play safe and apply the same here

- add dispose method to container service to start with a blank array whenever we route to another page, this is to avoid reusing already disposed services that might still be in the container service
- the issue was found in Angular-Slickgrid and did not seem to show up as a problem in Slickgrid-Universal itself but better play safe and apply the same here
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #712 (0fe7101) into master (1bcf7ad) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #712   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          233       233           
  Lines        16433     16438    +5     
  Branches      5486      5487    +1     
=========================================
+ Hits         16433     16438    +5     
Impacted Files Coverage Δ
packages/common/src/services/container.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)
...-bundle/src/services/universalContainer.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcf7ad...0fe7101. Read the comment docs.

@ghiscoding ghiscoding merged commit ec42dc7 into master Jul 6, 2022
@ghiscoding ghiscoding deleted the bugfix/composite-editor-row-selection-count branch July 6, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant