Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): update title prop on change event for Slider Filter/Editor #743

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 11, 2022

  • whenever the slider value changes, we should update its title property with the new value so that we can see what the value is with the tooltip when hovering the slider
  • also watch for extra mouseup and touchend events (not just change event) on the Slider Filter so that it works also properly with mobile devices (note that the Slider Editor already had these events and only the Slider Filters needed them)

- whenever the slider value changes, we should update its title property with the new value
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #743 (2635204) into master (c8acb65) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          233       233           
  Lines        16437     16440    +3     
  Branches      5490      5490           
=========================================
+ Hits         16437     16440    +3     
Impacted Files Coverage Δ
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
...ackages/common/src/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/extensionUtility.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 0ca6f3f into master Aug 11, 2022
@ghiscoding ghiscoding deleted the feat/slider-add-title-tooltip-on-slide branch August 11, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant