Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): fetch API isn't always an instance of Response #746

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ghiscoding
Copy link
Owner

  • same as previous PR fix(bundle): fetch API isn't always an instance of Response #744, this one was found after
  • the output of the Fetch API Promise isn't always an instanceof Response, the better way of validating the Fetch resolved output is to check its status to be between 200-300 and also make sure that it has the .json() type to be a function

- same as previous PR #744, this one was found after
- the output of the Fetch API Promise isn't always an `instanceof Response`, the better way of validating the Fetch resolved output is to check its status to be between 200-300 and also make sure that it has the `.json()` type to be a function
@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #746 (974a2d6) into master (9b09e4a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #746   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          233       233           
  Lines        16440     16440           
  Branches      5490      5490           
=========================================
  Hits         16440     16440           
Impacted Files Coverage Δ
packages/common/src/filters/filterUtilities.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 11be5c2 into master Aug 15, 2022
@ghiscoding ghiscoding deleted the bugfix/fetch-json-function-filter-utils branch August 15, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant