Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(filters): merge all Slider filters into one class #791

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

ghiscoding
Copy link
Owner

  • merge all 3 Slider Filters (single, compound & range) to avoid duplicate code and make the build slightly smaller

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #791 (f595008) into master (509a31d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #791    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          235       236     +1     
  Lines        16578     16402   -176     
  Branches      5554      5525    -29     
==========================================
- Hits         16578     16402   -176     
Impacted Files Coverage Δ
...ackages/common/src/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filters.index.ts 100.00% <100.00%> (ø)
packages/common/src/filters/index.ts 100.00% <100.00%> (ø)
packages/common/src/filters/singleSliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderRangeFilter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding changed the title perf(filters): merge all Slider filters perf(filters): merge all Slider filters into one class Nov 4, 2022
@ghiscoding ghiscoding merged commit fc4304b into master Nov 4, 2022
@ghiscoding ghiscoding deleted the feat/merge-all-slider-filters branch November 4, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant