Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): use editorOptions/filterOptions instead of params #798

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

ghiscoding
Copy link
Owner

  • instead of using editor/filter params which aren't typed, we'll move most of these options into existing or new interfaces and warn user of deprecations of editorOptions/filterOptions instead of params.

- instead of using editor/filter `params` which aren't typed, we'll move most of these options into existing or new interfaces and warn user of deprecations of editorOptions/filterOptions instead of params.
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #798 (da0ddfa) into master (91c4a5c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #798   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          236       237    +1     
  Lines        16454     16454           
  Branches      5550      5548    -2     
=========================================
  Hits         16454     16454           
Impacted Files Coverage Δ
.../src/commonEditorFilter/commonEditorFilterUtils.ts 100.00% <ø> (ø)
packages/common/src/editors/autocompleterEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/editorUtilities.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filterUtilities.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit a3c8b6e into master Nov 8, 2022
@ghiscoding ghiscoding deleted the bugfix/deprecate-editor-filter-params branch November 8, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant