Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Slider Range should update both number addons #803

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 10, 2022

  • new Slider code refactoring did not update slider input addon numbers on both side (left/right)

- new Slider code refactoring did not update slider input addon numbers on both side (left/right)
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #803 (9461c8e) into master (9c6be27) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #803   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          237       237           
  Lines        16460     16463    +3     
  Branches      5552      5556    +4     
=========================================
+ Hits         16460     16463    +3     
Impacted Files Coverage Δ
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/sliderFilter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 3cfd84e into master Nov 10, 2022
@ghiscoding ghiscoding deleted the bugfix/slider-input-change branch November 10, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant