Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): make Grid Menu item full width instead of max-content #858

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 22, 2022

Firefox seems to have problem with Grid Menu item width, I had to add a few Firefox (moz) only extra paddings/margins to compensate so that all items are showing the entire text. Chrome (WebKit) on the other end doesn't need these patch since it seems to add extra padding

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #858 (52a954b) into master (064e75e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #858   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16551     16551           
  Branches      5881      5881           
=========================================
  Hits         16551     16551           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 9c57365 into master Dec 22, 2022
@ghiscoding ghiscoding deleted the bugfix/grid-menu-firefox-full-width branch December 22, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant