Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataView): add option to apply row selection to all pages #882

Merged
merged 10 commits into from
Feb 4, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 28, 2023

  • this new feature will now make "Select All" checkbox work across all pages instead of just the current page, this feature will only work for local grid (when the entire dataset is provided)
  • note that this behavior is now enabled by default but user could disable it, via grid options, if he wants to go to previous behavior. gridOptions: { checkboxSelector: { applySelectOnAllPages: false } }

Note: the "Select All" will not change its behavior when used with BackendServiceApi (OData, GraphQL) since these service don't know anything from the other pages and IDs, it only has knowledge of its current page. So in that case, it will continue to Select All on the current page only

TODOs

  • require new SlickGrid version
  • requires new Cypress E2E tests
  • requires new Jest unit tests and changes to some of them

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #882 (5080fc2) into master (9f525e1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #882   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16567     16547   -20     
  Branches      5897      5890    -7     
=========================================
- Hits         16567     16547   -20     
Impacted Files Coverage Δ
...common/src/extensions/slickCheckboxSelectColumn.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 4aac7cb into master Feb 4, 2023
@ghiscoding ghiscoding deleted the feat/dataview-apply-row-selections-all-pages branch February 4, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant