Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): move TypeScript types into a single dist/types folder #905

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

ghiscoding
Copy link
Owner

No description provided.

- also remove browser, I don't think it's needed anymore since breakpoints are working fine now that we're exporting the main as ESM
- prior to this PR, TS Types were added to both CJS/ESM folders, but 1 common dist/types folder is easier to find and will lower our published build size by a lot
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #905 (983919e) into master (19b8a35) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #905   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16595     16595           
  Branches      5907      5907           
=========================================
  Hits         16595     16595           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding changed the title feat(build): move TypeScript types into a single dist/types folder WIP - feat(build): move TypeScript types into a single dist/types folder Feb 16, 2023
@ghiscoding ghiscoding changed the title WIP - feat(build): move TypeScript types into a single dist/types folder feat(build): move TypeScript types into a single dist/types folder Feb 17, 2023
@ghiscoding ghiscoding merged commit b139c1e into master Feb 17, 2023
@ghiscoding ghiscoding deleted the chore/separate-type-exports branch February 17, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant