-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(presets): dynamic columns should be auto-inserted with Grid Presets #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this PR fixes 2 issues 1. when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see print screen) 2. there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when columns presets are used
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 244 244
Lines 16604 16618 +14
Branches 5906 5915 +9
=========================================
+ Hits 16604 16618 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Mar 23, 2023
- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets - the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen) - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
2 tasks
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Mar 23, 2023
…ts (#955) * fix(presets): dynamic columns should be auto-inserted with Grid Presets - there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets - the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen) - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
ghiscoding
added a commit
to ghiscoding/slickgrid-react
that referenced
this pull request
Mar 23, 2023
- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets - the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen) - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
ghiscoding
added a commit
to ghiscoding/slickgrid-react
that referenced
this pull request
Mar 23, 2023
…ts (#74) - there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets - the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen) - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
field
name "sel" causing duplicate checkboxes (see print screen)