Wont build on FreeBSD 12

[william-gr]

Hi, apparently FreeBSD 12 (current) have some changes which breaks psutil:

cc -DNDEBUG -pipe -g -fstack-protector -fno-strict-aliasing -fPIC -DPSUTIL_VERSION=430 -I/usr/local/include/python3.6m -c psutil/arch/bsd/freebsd_socks.c -o build/temp.freebsd-12.0-CURRENT-amd64-3.6/psutil/arch/bsd/freebsd_socks.o
psutil/arch/bsd/freebsd_socks.c:127:39: error: no member named 'xt_tp' in 'struct xtcpcb'
        tp = &((struct xtcpcb *)xig)->xt_tp;
              ~~~~~~~~~~~~~~~~~~~~~~  ^
psutil/arch/bsd/freebsd_socks.c:128:13: warning: incompatible pointer types assigning to 'struct inpcb *' from 'struct xinpcb *' [-Wincompatible-pointer-types]
        inp = &((struct xtcpcb *)xig)->xt_inp;
            ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
psutil/arch/bsd/freebsd_socks.c:129:39: error: no member named 'xt_socket' in 'struct xtcpcb'
        so = &((struct xtcpcb *)xig)->xt_socket;
              ~~~~~~~~~~~~~~~~~~~~~~  ^
psutil/arch/bsd/freebsd_socks.c:138:33: error: incomplete definition of type 'struct inpcb'
                    AF_INET, inp->inp_lport, &inp->inp_laddr,
                             ~~~^
/usr/include/netinet/in_pcb.h:65:22: note: forward declaration of 'struct inpcb'
LIST_HEAD(inpcbhead, inpcb);
                     ^

building for: FreeBSD ja-freenas-head-p-job-02 12.0-CURRENT FreeBSD 12.0-CURRENT amd64
Host OSVERSION: 1200027

Let me know if there is anything else I can provide. Thanks.

[giampaolo]

Damn... :(
I don't have a FreeBSD 12 to test against, nor will have time to set it up on virtualbox any time soon.

[giampaolo]

It turns out I found time. I installed FreeBSD12 and I can see a long list of errors about incomplete or missing members of structs. It looks like FreeBSD12 broke backward compatibility pretty badly. It doesn't look promising. FWIW I tried to post on freebsd-dev forum asking for help:
https://forums.freebsd.org/threads/60846/

[giampaolo]

Fix in FreeBSD ports: freebsd/freebsd-ports@f884342#diff-b206b874d1a005284d13a30265ee495b.

[william-gr]

Awesome, thanks!

[glebius]

Yes, please include the patch from ports into next psutil release. Thanks!