Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for MidnightBSD #1996

Merged
merged 1 commit into from
Oct 12, 2021
Merged

add support for MidnightBSD #1996

merged 1 commit into from
Oct 12, 2021

Conversation

ilius
Copy link
Contributor

@ilius ilius commented Oct 9, 2021

Summary

  • OS: MidnightBSD 2.1.1
  • Bug fix: Fix error platform MidnightBSD is not supported"
  • Type: scripts

Description

MidnightBSD is a fork of FreeBSD:
https://www.midnightbsd.org/
https://distrowatch.com/table.php?distribution=midnightbsd

It would be nice to support all forks of FreeBSD without listing them.

Just for the record, here is the top FreeBSD forks/distros:
https://distrowatch.com/search.php?basedon=FreeBSD#simple

@giampaolo
Copy link
Owner

Mmm did you run tests? Are there failures?

@ilius ilius force-pushed the midnightbsd branch 2 times, most recently from 996c32d to 2de61c2 Compare October 11, 2021 18:06
@ilius
Copy link
Contributor Author

ilius commented Oct 11, 2021

psutil.test() works, but unit tests fail
https://gist.github.com/ilius/768a99c9171edefb3701ade2e485644a

psutil/_common.py Outdated Show resolved Hide resolved
psutil/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: Saeed Rasooli <saeed.gnu@gmail.com>
@ilius
Copy link
Contributor Author

ilius commented Oct 12, 2021

Thanks.
Updated.
I can also test this with DragonFly BSD and add another PR.

@giampaolo
Copy link
Owner

Yes, please. In general, I'm against adding support for exotic/rare platforms, but if they require no changes other than what you're doing in here, then I'm OK.

@giampaolo giampaolo merged commit 9825ca2 into giampaolo:master Oct 12, 2021
giampaolo added a commit that referenced this pull request Oct 12, 2021
Signed-off-by: Giampaolo Rodola <g.rodola@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants