Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process wait() should check PID has not been reused #365

Closed
giampaolo opened this issue May 23, 2014 · 6 comments
Closed

Process wait() should check PID has not been reused #365

giampaolo opened this issue May 23, 2014 · 6 comments
Assignees

Comments

@giampaolo
Copy link
Owner

From g.rodola on April 11, 2013 11:12:37

...so that we don't wait on another process' PID.
Note that Process class guarantees this security only for "sensitive" methods 
such as kill(), send_signal(), etc..
Other methods (basically all get_* methods) doesn't have such guarantee.

Original issue: http://code.google.com/p/psutil/issues/detail?id=365

@giampaolo giampaolo self-assigned this May 23, 2014
@giampaolo
Copy link
Owner Author

From g.rodola on April 11, 2013 02:16:42

Fixed in revision d32bfe6af5c4 .

Status: FixedInHG

@giampaolo
Copy link
Owner Author

From g.rodola on April 11, 2013 02:17:40

Labels: -Milestone-0.6.2 Milestone-0.7.0

@giampaolo
Copy link
Owner Author

From g.rodola on April 11, 2013 02:55:38

set_nice() should use the same check. Done in revision d514e4e43e5c .

@giampaolo
Copy link
Owner Author

From g.rodola on April 11, 2013 06:29:34

It turned out it's wiser to avoid the PID reuse check on Windows as per 
revision e305df5644c3 .

@giampaolo
Copy link
Owner Author

From g.rodola on April 11, 2013 13:17:41

Reverted the wait() change as per revision 4ab86014a0c8 (rationale is in the 
commit message).

@giampaolo
Copy link
Owner Author

From g.rodola on April 12, 2013 11:21:27

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant