Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capa-iam-operator refactoring #2113

Closed
alex-dabija opened this issue Mar 7, 2023 · 0 comments
Closed

capa-iam-operator refactoring #2113

alex-dabija opened this issue Mar 7, 2023 · 0 comments
Assignees
Labels
kind/chore provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix

Comments

@alex-dabija
Copy link

alex-dabija commented Mar 7, 2023

Task

capa-iam-operator refactoring.

  • We should have a central library for idempotent, well-tested functions (such as getOrCreateIAMRole, upsertIAMPolicyForRole, ...)
  • Remove tests that only check internals without reconcilation (template_test.go)
  • Specify at one place which roles we want to have and don't call external-dns "Route53"
  • We seem to attach two equal policies each (e.g. control-plane-*-policy vs. irsa-role-*-policy). Fix that.
  • Cluster should clean up all the bad stuff it created in its older versions :(
  • Since the 3 controllers do the same, they should share most code. Also, we should lock a mutex while calling the AWS SDK, since otherwise we may get false-positive errors while creating the same object at the same time.
  • Check if we really need to have a finalizer on the AWSCluster object or if we could even live without fetching that object at all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore provider/cluster-api-aws Cluster API based running on AWS team/phoenix Team Phoenix
Projects
None yet
Development

No branches or pull requests

4 participants