Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opsctl notify release for CAPV and CAPVCD #3764

Closed
yulianedyalkova opened this issue Nov 12, 2024 · 2 comments
Closed

Update opsctl notify release for CAPV and CAPVCD #3764

yulianedyalkova opened this issue Nov 12, 2024 · 2 comments
Assignees
Labels
team/rocket Team Rocket

Comments

@yulianedyalkova
Copy link

yulianedyalkova commented Nov 12, 2024

Currently opsctl notify release is not implemented to deal with CAPV and CAPVCD clusters (as we didn't use releases there before).

For CAPV it returns an empty list:

opsctl notify release --file announcement.md --customers --provider vsphere --md-to-slack

For cloud-director it returns one customer.

@yulianedyalkova yulianedyalkova converted this from a draft issue Nov 12, 2024
@architectbot architectbot added the team/rocket Team Rocket label Nov 25, 2024
@anvddriesch
Copy link

I looked at the command and it is getting the customers and their slack channels based on the information in the installations repo. (it is the same as what you see in opsctl list installations
It technically works just fine for CAPV and CAPVCD and shows the one customer who maintains an MC in CAPVCD. The others don't appear because while they use the releases, their MCs are on other providers and therefore labelled differently in the installations repo.
As it is we can't simply add another provider to an installation or at least we should make a conscious decision on how we should do it. Let me bring it to sig arch

@anvddriesch
Copy link

We decided to add an optional additionalProviders field in the installations repo which can contain a list of other providers than the primary provider.
We will also adjust notify release to respect this field.

@github-project-automation github-project-automation bot moved this from In Progress ⛏️ to Done ✅ in Roadmap Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/rocket Team Rocket
Projects
Archived in project
Development

No branches or pull requests

3 participants