Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long values #2

Closed
OliverJAsh opened this issue May 31, 2017 · 3 comments · Fixed by #32
Closed

Truncate long values #2

OliverJAsh opened this issue May 31, 2017 · 3 comments · Fixed by #32

Comments

@OliverJAsh
Copy link
Collaborator

We should truncate long values to avoid ridiculously long strings.

@osdiab
Copy link
Contributor

osdiab commented May 23, 2020

Unless the truncation is smart about what it clips I’d more prefer smarter decisions of what to display

For instance something like a union type of two complex interfaces failing up the chain because of a value really deep inside - if we can identify just the key and type of that leaf value instead and print out the path, it would avoid super long types and probably be sufficient to cut down most long errors

Cc @gillchristian if that’s something your PR can potentially do

@osdiab
Copy link
Contributor

osdiab commented May 23, 2020

Also potentially deduping and merging types with the same paths

@osdiab
Copy link
Contributor

osdiab commented Jun 18, 2020

In retrospect now I do think some truncation makes sense - sometimes if a value is just missing altogether then being smart about paths and what not doesn't really help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants