New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write/macho: ARM64_RELOC_ADDEND support doesn't seem correct #580

Closed

philipc opened this issue Oct 5, 2023 · 0 comments · Fixed by #581

Contributor

philipc commented Oct 5, 2023

There's a few issues:

we write an extra relocation but don't increase the number of relocations in the section header
we write the ARM64_RELOC_ADDEND after the paired relocation, but the documentation says it should come first
we should support this for ARM64_RELOC_PAGE21 and ARM64_RELOC_PAGEOFF12 as well

This probably needs to be fixed for https://github.com/bjorn3/rustc_codegen_cranelift/issues/1248

The text was updated successfully, but these errors were encountered:

philipc mentioned this issue

Mach-O AArch64 relocation addend improvements #581

Merged

philipc closed this as completed in #581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment