Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ratatui as default feature in place of tui #45

Closed
Kryszak opened this issue Aug 29, 2023 · 5 comments · Fixed by #49
Closed

Set ratatui as default feature in place of tui #45

Kryszak opened this issue Aug 29, 2023 · 5 comments · Fixed by #49

Comments

@Kryszak
Copy link

Kryszak commented Aug 29, 2023

As for 6 August 2023 tui repository is archived fdehau/tui-rs#654.
I think it's time to make ratatui feature default one and tui support as legacy feature.
It might make it easier to keep up with new versions of ratatui (as for now tui-logger 0.9.5 doesn't work with ratatui 0.23.0.

@gin66
Copy link
Owner

gin66 commented Aug 30, 2023

Thanks for the hint. Actually, in this case tui support can be dropped and just point to the latest compatible one.

@Kryszak
Copy link
Author

Kryszak commented Aug 31, 2023

That's even better idea, for tui there are older crate versions. Looking forward to the updates!

@orhun
Copy link
Contributor

orhun commented Sep 11, 2023

I totally second this!

@gin66
Copy link
Owner

gin66 commented Sep 14, 2023

will make the change in next official release as soon as I have time.

@gin66
Copy link
Owner

gin66 commented Sep 17, 2023

Just have found out, that ratatui 0.23.0 still compiles with tui_logger, so I will keep it for now and the issue can be kept open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants