Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ratatui to 0.28 #65

Closed

Conversation

tomgroenwoldt
Copy link
Contributor

Hi, I'm currently in the process of using your crate and so far it worked out quite nice for my use case. The only problem I faced was conflicting ratatui versions.

This PR updates ratatui to 0.28 and adjusts the (now) deprecated functions.

@gin66
Copy link
Owner

gin66 commented Aug 18, 2024

Thanks for the patch.

@gin66 gin66 closed this Aug 18, 2024
@sgrimee
Copy link

sgrimee commented Aug 18, 2024

Thank you, I was waiting for this!
Small suggestion to update to 0.12.0, not just 0.11.3 as it is a breaking change.
Cheers!

@gin66
Copy link
Owner

gin66 commented Aug 18, 2024

Strange. The patch has not shown up in master. Perhaps I have pressed the wrong button. Anyway, I have then manually updated master to that commit and bumped the version to 0.12.0.

The semver check has not flagged a problem with 0.11.3. Wonder, if/how that works

@sgrimee
Copy link

sgrimee commented Aug 18, 2024

My reasoning was that upgrading ratatui will cause multiple versions of ratatui to be installed for apps that use tui-logger, often causing conflicts.
As it is a 0.x release, this comment from the book applies:
"This compatibility convention is different from SemVer in the way it treats versions before 1.0.0. While SemVer says there is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.
"

@tomgroenwoldt tomgroenwoldt deleted the update-ratatui-to-0.28 branch August 18, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants