Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the LCMS datasets to the sankee GUI #517

Closed
aazuspan opened this issue Jun 6, 2021 · 7 comments · Fixed by #518
Closed

Add the LCMS datasets to the sankee GUI #517

aazuspan opened this issue Jun 6, 2021 · 7 comments · Fixed by #518
Assignees
Labels
Feature Request New feature or request

Comments

@aazuspan
Copy link
Contributor

aazuspan commented Jun 6, 2021

Description

I just added an LCMS land cover dataset to sankee v0.0.4. Having that accessible through the GUI would be great since it gives the longest, most consistent time series of any of the datasets.

If you like, I can make a PR to add it!

@aazuspan aazuspan added the Feature Request New feature or request label Jun 6, 2021
@giswqs
Copy link
Member

giswqs commented Jun 6, 2021

That's great! PR is welcome.

@giswqs
Copy link
Member

giswqs commented Jun 6, 2021

The relevant function is sankee_gui. Let me know if you have any questions.

@rcr-usfs
Copy link

I work on the LCMS production team. We really like this feature! Just a heads up that LCMS has an updated version that goes through 2021 for CONUS and SEAK. https://developers.google.com/earth-engine/datasets/catalog/USFS_GTAC_LCMS_v2021-7. Thanks a lot!

@giswqs
Copy link
Member

giswqs commented Jun 29, 2022

@rcr-usfs Thanks for the heads up. I guess the dataset needs to be updated by the sankee package @aazuspan. I can then updated the GUI if needed.

@rcr-usfs
Copy link

Thanks for the quick reply! That sounds great! Since LCMS models land cover and land use separately, it would be really useful to have the land use (.select(['Land_Use'])) in there as well @aazuspan . Thanks a lot!

@aazuspan
Copy link
Contributor Author

It looks like there weren't any changes to the LULC key with the 2021 update, so the LCMS datasets in sankee should work fine with the new collection. They do reference the deprecated collection which I need to fix, but that shouldn't cause any functional issues. @giswqs I think the GUI just needs to be updated to include the 2021 year and point to the new collection. Also, sankee includes the LU and LC datasets separately, so the land use band could be added as an additional dataset option.

I can make those changes (and update the year ranges for the other datasets while I'm at it) and make a PR.

Keep up the good work on LCMS, @rcr-usfs!

@giswqs
Copy link
Member

giswqs commented Jun 30, 2022

@aazuspan That would be great! Looking forward to your PR.

aazuspan added a commit to aazuspan/geemap that referenced this issue Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants