Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tag_filter_pattern in config options #72

Merged
merged 1 commit into from
Jan 9, 2021
Merged

feat: enable tag_filter_pattern in config options #72

merged 1 commit into from
Jan 9, 2021

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Apr 19, 2020

What does this do / why do we need it?

enable tag-filter-pattern in config options

What should your reviewer look out for in this PR?

if options in config file works and can be overwrited by args

Check lists

  • Test passed
  • Coding style (indentation, etc)

Which issue(s) does this PR fix?

close #70

@coveralls
Copy link

Pull Request Test Coverage Report for Build 159

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.207%

Totals Coverage Status
Change from base Build 155: 0.02%
Covered Lines: 1632
Relevant Lines: 2170

💛 - Coveralls

@rohitchawla22
Copy link

@trim21 Can we merge this PR in?
We are trying to achieve something similar where we want to generate changelogs separately for versions 2.* and a different one for versions 1.*
As both the versions of our application currently live in the same repository, git-chglog is not able to differentiate between two different versions.
Thanks

@trim21
Copy link
Contributor Author

trim21 commented Jun 8, 2020

It's ready to be merged

@mithuns
Copy link

mithuns commented Jul 18, 2020

Whats blocking this, I think this is a great feature.

@trim21
Copy link
Contributor Author

trim21 commented Jul 18, 2020

@mithuns I guess it's just because nobody is merging pr

@mithuns
Copy link

mithuns commented Jul 18, 2020

Why is the travis-ci not running ? I think that is a required check.

@estahn
Copy link

estahn commented Nov 17, 2020

Any update on this? I guess this will also help with monorepos?

@trim21
Copy link
Contributor Author

trim21 commented Nov 17, 2020

@trim21 trim21 mentioned this pull request Jan 8, 2021
2 tasks
@mavogel
Copy link
Member

mavogel commented Jan 9, 2021

Thanks @trim21 ! We gonna fix the ci and release process separately and most probably move to gh-actions in #58. I gonna overrule the failed travis check, which succeeded as mentioned on the link above

@mavogel mavogel merged commit 75d59a9 into git-chglog:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: tag-filter-pattern as a config option
6 participants