Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC cloud-specific docs are missing environment variables #11620

Closed
1 task done
aripollak opened this issue Nov 2, 2021 · 4 comments
Closed
1 task done

OIDC cloud-specific docs are missing environment variables #11620

aripollak opened this issue Nov 2, 2021 · 4 comments
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@aripollak
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services

What part(s) of the article would you like to see updated?

In the "Requesting the access token" section, the places that use environment variables just show $ instead of the actual environment variables, like:
aws-region: $
should show
aws-region: ${{ env.AWS_REGION }}

Additional information

No response

@aripollak aripollak added the content This issue or pull request belongs to the Docs Content team label Nov 2, 2021
@welcome
Copy link

welcome bot commented Nov 2, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 2, 2021
@ramyaparimi ramyaparimi added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 3, 2021
@ramyaparimi
Copy link
Contributor

@aripollak
Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@ramyaparimi ramyaparimi added the actions This issue or pull request should be reviewed by the docs actions team label Nov 3, 2021
@Kelventri
Copy link

Gracias por abrir este número. Un miembro del equipo de documentos de GitHub debería estar cerca para enviar comentarios pronto. Mientras tanto, consulte las pautas de contribución .

@hubwriter
Copy link
Contributor

@aripollak - Thanks for raising this issue.
This has been fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

6 participants
@aripollak @ramyaparimi @hubwriter @Kelventri and others