Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-code-owners.md #34699

Closed
1 task done
daczarne opened this issue Sep 23, 2024 · 4 comments · Fixed by #34698
Closed
1 task done

Update about-code-owners.md #34699

daczarne opened this issue Sep 23, 2024 · 4 comments · Fixed by #34698
Labels
content This issue or pull request belongs to the Docs Content team repositories Content related to repositories

Comments

@daczarne
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

What part(s) of the article would you like to see updated?

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file

Additional information

The wording might be interpreted incorrectly by users leading them to believe that statements like

/apps/github

will cause the ownership of that subfolder to revert back to a previously defined owner, when this is not the case.

@daczarne daczarne added the content This issue or pull request belongs to the Docs Content team label Sep 23, 2024
Copy link

welcome bot commented Sep 23, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@docs-bot
Copy link
Collaborator

This issue may have been opened accidentally. I'm going to close it now, but feel free to open a new issue with a more descriptive title!

@docs-bot docs-bot added invalid This issue/PR is invalid and removed content This issue or pull request belongs to the Docs Content team labels Sep 23, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 23, 2024
@nguyenalex836 nguyenalex836 removed the invalid This issue/PR is invalid label Sep 23, 2024
@nguyenalex836 nguyenalex836 reopened this Sep 23, 2024
@nguyenalex836 nguyenalex836 added the repositories Content related to repositories label Sep 23, 2024
@nguyenalex836
Copy link
Contributor

@daczarne Apologies for our overzealous bot - thank you for opening an issue and linking it to your PR! ✨

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Sep 23, 2024
@daczarne
Copy link
Contributor Author

daczarne commented Sep 23, 2024

@daczarne Apologies for our overzealous bot - thank you for opening an issue and linking it to your PR! ✨

No problem at all. Thanks for taking a look.

It was just a situation we ran into today at work. Several devs and we all interpreted the doc in the wrong way. Thought this would be the best way of sharing our findings 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team repositories Content related to repositories
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@daczarne @docs-bot @nguyenalex836 and others