Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing parameter description in REST API docs for /users #472

Closed
abhijit-hota opened this issue Oct 13, 2020 · 4 comments
Closed

Confusing parameter description in REST API docs for /users #472

abhijit-hota opened this issue Oct 13, 2020 · 4 comments
Assignees
Labels
ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Comments

@abhijit-hota
Copy link

abhijit-hota commented Oct 13, 2020

What is the current behavior?

I was browsing through the REST API docs for Users and I couldn't quite get this piece of description (bordered in orange):

What changes are you suggesting?

I think the parameter description for since is confusing/wrong and should be corrected.

Additional information

Opened a discussion here and came to know that it was an issue.
Edit: As @felicitymay described here, the type pf since might also be wrong.

@abhijit-hota abhijit-hota added the engineering Will involve Docs Engineering label Oct 13, 2020
@welcome
Copy link

welcome bot commented Oct 13, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 13, 2020
@runleonarun runleonarun added ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team and removed engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team labels Oct 13, 2020
@runleonarun
Copy link
Contributor

runleonarun commented Oct 13, 2020

Nice catch, @abhijit-hota! The since parameter should be an integer and it should say something like, "The ID of the user where you want to begin the list of users."

Note that we need to fix this issue in an internal repo, but we will report back here when its fixed!

@abhijit-hota
Copy link
Author

Thanks!

The since parameter should be an integer and it should say something like, "The ID of the user where you want to begin the list of users."

Yep. Got it. My two cents:

The word since is used in context of time and that's the reason I did not doubt the timestamp type.
But, the input is an ID. So IMO, it should be something like from or fromID to avoid confusion. (I'm not suggesting the change to the docs team but to the API developers although changing the API may break some applications that use this param. 😅)

but we will report back here when its fixed!

Great!

@skedwards88 skedwards88 self-assigned this Oct 16, 2020
@skedwards88
Copy link
Contributor

https://github.com/github/docs-content/issues/3116 will address this as well as the other places where the since parameter is mis-documented. I am closing this issue to avoid duplication. Thank you for bringing it to our attention!

The word since is used in context of time and that's the reason I did not doubt the timestamp type.
But, the input is an ID. So IMO, it should be something like from or fromID to avoid confusion. (I'm not suggesting the change to the docs team but to the API developers although changing the API may break some applications that use this param. 😅)

Great suggestion! I I have created an issue for the API team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

No branches or pull requests

3 participants