Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 Update configuring-openid-connect-in-google-cloud-platform.md #32405

Closed
wants to merge 1 commit into from
Closed

#42 Update configuring-openid-connect-in-google-cloud-platform.md #32405

wants to merge 1 commit into from

Conversation

conorheffron
Copy link
Contributor

@conorheffron conorheffron commented Apr 6, 2024

Why:

What part(s) of the article would you like to see updated?
The article currently reads:

: Replace this with the path to your identity provider in GCP. For example, projects//locations/global/workloadIdentityPools/<name-of-pool/providers/

In the portion after "For example", the text .

Closes:

#42

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/workflows/**
  • .github/CODEOWNERS
  • assets/fonts/**
  • data/graphql/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/*/scripts/**
  • src/**.json
  • src/workflows/**
  • lib/redirects/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@conorheffron conorheffron changed the title #42 Update configuring-openid-connect-in-google-cloud-platform.md #42 Update configuring-openid-connect-in-google-cloud-platform.md [![Check unallowed file changes](https://github.com/github/docs/actions/workflows/triage-unallowed-contributions.yml/badge.svg?branch=main&event=pull_request_review)](https://github.com/github/docs/actions/workflows/triage-unallowed-contributions.yml) Apr 6, 2024
@conorheffron
Copy link
Contributor Author

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • content/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-google-cloud-platform.md

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/workflows/**
  • .github/CODEOWNERS
  • assets/fonts/**
  • data/graphql/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/*/scripts/**
  • src/**.json
  • src/workflows/**
  • lib/redirects/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Check unallowed file changes

@conorheffron conorheffron changed the title #42 Update configuring-openid-connect-in-google-cloud-platform.md [![Check unallowed file changes](https://github.com/github/docs/actions/workflows/triage-unallowed-contributions.yml/badge.svg?branch=main&event=pull_request_review)](https://github.com/github/docs/actions/workflows/triage-unallowed-contributions.yml) #42 Update configuring-openid-connect-in-google-cloud-platform.md Apr 6, 2024
@conorheffron conorheffron deleted the 42-typo branch April 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant