Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint-plugin-graphql to 2.1.0 #35

Closed
wants to merge 1 commit into from
Closed

update eslint-plugin-graphql to 2.1.0 #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"babel-eslint": ">=8.0.0",
"eslint-config-prettier": ">=2.6.0",
"eslint-plugin-flowtype": ">=2.36.0",
"eslint-plugin-graphql": ">=2.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't ">=2.0.0" already allow for 2.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol that's a good point. I got all exicted and opened up the PR. This should just work™️ in devtools now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it's not updating on my machine:

☁  devtools [master] rm -rf node_modules
☁  devtools [master] npm install

> fsevents@1.1.3 install /Users/koddsson/github/devtools/node_modules/fsevents
> node install

[fsevents] Success: "/Users/koddsson/github/devtools/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node" is installed via remote

> uglifyjs-webpack-plugin@0.4.6 postinstall /Users/koddsson/github/devtools/node_modules/uglifyjs-webpack-plugin
> node lib/post_install.js

added 1772 packages in 67.799s
☁  devtools [master] cat node_modules/eslint-plugin-graphql/package.json | jq .version
"2.0.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I need to just refresh the package-lock.json in devtools I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that's it, I'll make a PR in devtools.

"eslint-plugin-graphql": "^2.1.0",
"eslint-plugin-import": ">=2.7.0",
"eslint-plugin-jest": ">=21.0.0",
"eslint-plugin-jsx-a11y": ">=6.0.0",
Expand Down