Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Salesforce Blue colour for Salesforce Apex #4417

Closed
wants to merge 3 commits into from
Closed

Add Salesforce Blue colour for Salesforce Apex #4417

wants to merge 3 commits into from

Conversation

davidsbond
Copy link

Currently, Apex doesn't have a colour. It should use the Salesforce blue

Added Salesforce blue hex code for Salesforce Apex
Put hex codes in quotes
@davidsbond davidsbond changed the title Update languages.yml Add Salesforce Blue colour for Salesforce Apex Feb 12, 2019
Trying a different blue that Salesforce also use
@Alhadis
Copy link
Collaborator

Alhadis commented Feb 13, 2019

@davidsbond The colour is (currently) too close to those of other languages, which is causing the colour proximity test to fail.

Hold off on attempting a fix, however. It's possible (🤞) that the GitHub team will drop the colour difference requirement now that language bars have dividers to separate colours. @lildude is currently waiting on feedback from the rest of the team, so if all goes well, we can use the official Salesforce blue instead of a compromise.

@stale
Copy link

stale bot commented Mar 15, 2019

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Mar 15, 2019
@Alhadis Alhadis removed the Stale label Mar 15, 2019
@Alhadis Alhadis self-assigned this Mar 15, 2019
@davidsbond davidsbond closed this Apr 24, 2019
@Alhadis
Copy link
Collaborator

Alhadis commented Apr 24, 2019

@davidsbond I'll make a note to update Salesforce's colour should GitHub's colour-proximity restriction be lifted in future. 👍

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants