Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ruby/node and setup local development #1276

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Dec 9, 2024

  • devcontainer

  • upgrade ruby (was 3.3.1, now 3.3.3)

  • upgrade node (was 12, now 23)

  • update README

  • fix deprecated warnings about script/bootstrap

    • [DEPRECATED] The --path flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use bundle config set path 'vendor/gems', and stop using this flag
    • [DEPRECATED] The --binstubs option will be removed in favor of bundle binstubs --all
  • Have you followed the contributing guidelines?

  • Have you explained what your changes do, and why they add value?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@jmeridth jmeridth self-assigned this Dec 9, 2024
@jmeridth jmeridth requested a review from a team as a code owner December 9, 2024 02:11
@jmeridth jmeridth force-pushed the jm_upgrades_and_local_dev branch 2 times, most recently from eaa334f to ef7f909 Compare December 9, 2024 02:14
- [x] devcontainer
- [x] upgrade ruby (was 3.3.1, now 3.3.3)
- [x] upgrade node (was 12, now 23)
- [x] update README
- [x] fix deprecated warnings about `script/bootstrap`
  - [DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set path 'vendor/gems'`, and stop using this flag
  - [DEPRECATED] The --binstubs option will be removed in favor of `bundle binstubs --all`

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth force-pushed the jm_upgrades_and_local_dev branch from ef7f909 to 08edccb Compare December 9, 2024 02:29
@jmeridth jmeridth merged commit 98e00e1 into main Dec 9, 2024
5 checks passed
@jmeridth jmeridth deleted the jm_upgrades_and_local_dev branch December 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants