diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..9529e05 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +# Automatically add our team to each pull request in this repo +* @github/pages-reviewers diff --git a/.github/workflows/pages-gem.yml b/.github/workflows/pages-gem.yml index 281512f..4f75e2b 100644 --- a/.github/workflows/pages-gem.yml +++ b/.github/workflows/pages-gem.yml @@ -4,6 +4,9 @@ on: release: types: [released] +permissions: + contents: read + jobs: release: runs-on: ubuntu-latest @@ -11,12 +14,14 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Setup Ruby - uses: ruby/setup-ruby@v1 + uses: ruby/setup-ruby@52753b7da854d5c07df37391a986c76ab4615999 # v1.191.0 with: ruby-version: '3.2' - name: Build gem run: | - gem build github-pages.gemspec - - name: Publish + gem build github-pages-health-check.gemspec + - name: Publish gem + env: + GEM_HOST_API_KEY: ${{ secrets.PAGES_GEM_PUBLISHING }} run: | - gem push github-pages.gem --key ${{ secrets.PAGES_GEM_PUBLISH }} + gem push github-pages-health-check-*.gem diff --git a/.github/workflows/push-cibuild.yml b/.github/workflows/push-cibuild.yml index 95eef5b..daf389c 100644 --- a/.github/workflows/push-cibuild.yml +++ b/.github/workflows/push-cibuild.yml @@ -1,5 +1,7 @@ on: push name: "GitHub Pages Health Check Tests" +permissions: + contents: read jobs: build: name: "GitHub Pages Health Check Tests" diff --git a/github-pages-health-check.gemspec b/github-pages-health-check.gemspec index 32dd25b..fcb2dcb 100644 --- a/github-pages-health-check.gemspec +++ b/github-pages-health-check.gemspec @@ -18,7 +18,7 @@ Gem::Specification.new do |s| s.add_dependency("addressable", "~> 2.3") s.add_dependency("dnsruby", "~> 1.60") - s.add_dependency("octokit", ">= 4", "< 9") - s.add_dependency("public_suffix", ">= 3.0", "< 6.0") + s.add_dependency("octokit", ">= 4", "< 10") + s.add_dependency("public_suffix", ">= 3.0", "< 7.0") s.add_dependency("typhoeus", "~> 1.3") end diff --git a/lib/github-pages-health-check/domain.rb b/lib/github-pages-health-check/domain.rb index f36bf7d..83097f2 100644 --- a/lib/github-pages-health-check/domain.rb +++ b/lib/github-pages-health-check/domain.rb @@ -283,7 +283,7 @@ def pages_dot_github_dot_com? # Is this domain owned by GitHub? def github_domain? - !!host.downcase.end_with?("github.com") + host.downcase.eql?("github.com") || host.downcase.end_with?(".github.com") end # Is the host our Fastly CNAME? diff --git a/spec/github_pages_health_check/domain_spec.rb b/spec/github_pages_health_check/domain_spec.rb index 7784347..554dc89 100644 --- a/spec/github_pages_health_check/domain_spec.rb +++ b/spec/github_pages_health_check/domain_spec.rb @@ -535,6 +535,14 @@ end end + context "not github domains" do + let(:domain) { "somethinggithub.com" } + + it "knows if the domain is not a github domain" do + expect(subject).to_not be_a_github_domain + end + end + context "fastly domain" do let(:domain) { "github.map.fastly.net" }